Incorrect indices of numeric and alpha fields used for input error reporting in Variable Speed DX Coils #11013
Description
Issue overview
While working on a new feature, I found typos in the get input error messages pointing to incorrect indices of Numeric and Alpha fields in multiple places.
Operating System (Multiple choices)
Any
Operating System Version
25.1; develop
Version of EnergyPlus
25.1; develop
Unmethours link or helpdesk ticket number
N/A
Defect file
(1) Incorrect index for error message related to Crank Case Heater Capacity get input field here. The index to cNumericFields(9) and NumAlpha(9) should have been 8, not 9.
// Set crankcase heater capacity
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).CrankcaseHeaterCapacity = NumArray(8);
if (state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).CrankcaseHeaterCapacity < 0.0) {
ShowSevereError(
state,
format("{}{}=\"{}\", invalid", RoutineName, CurrentModuleObject, state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).Name));
ShowContinueError(state, format("...{} cannot be < 0.0.", cNumericFields(9)));
ShowContinueError(state, format("...entered value=[{:.2T}].", NumArray(9)));
ErrorsFound = true;
}
(2) Incorrect index for error message for the Defrost Time input field here. The index to cNumericFields(5) should have been 10.
// Set defrost time period
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).DefrostTime = NumArray(10);
if (state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).DefrostTime == 0.0 &&
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).DefrostControl == 1) {
ShowWarningError(
state, format("{}{}=\"{}\", ", RoutineName, CurrentModuleObject, state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).Name));
ShowContinueError(state, format("...{} = 0.0 for defrost control = TIMED.", cNumericFields(5)));
}
(3) Incorrect index for error message for the Defrost Capacity input field here. The index to cNumericFields(6) should have been 11.
// Set defrost capacity (for resistive defrost)
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).DefrostCapacity = NumArray(11);
if (state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).DefrostCapacity == 0.0 &&
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).DefrostStrategy == 2) {
ShowWarningError(
state, format("{}{}=\"{}\", ", RoutineName, CurrentModuleObject, state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).Name));
ShowContinueError(state, format("...{} = 0.0 for defrost strategy = RESISTIVE.", cNumericFields(6)));
}
(4) Incorrect index for error message for the Total Rated Capacity input field here. The index "cNumericFields(12 + (I - 1) * 3)" should have been "cNumericFields(12 + (I - 1) * 5)".
if (state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).MSRatedTotCap(I) < 1.e-10) {
ShowSevereError(state,
format("{}{}=\"{}\", invalid value",
RoutineName,
CurrentModuleObject,
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).Name));
ShowContinueError(state,
format("...too small {}=[{:.2R}].",
cNumericFields(12 + (I - 1) * 3),
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).MSRatedTotCap(I)));
ErrorsFound = true;
}