Site:GroundReflectance:SnowModifier may use incorrect default for daylighting #10360
Description
Issue overview
Site:GroundReflectance:SnowModifier has two fields, one for solar gains and one for daylighting, and both default to 1.0.
Site:GroundReflectance:SnowModifier,
1.0; !- Ground Reflected Solar Modifier
1.0; !- Daylighting Ground Reflected Solar Modifier
If this object is not present in the input file, then both field default to 1.0 - no problem here.
But, if only the first field is specified, then the second field will be zero (due to incorrect input processing). e.g.
Site:GroundReflectance:SnowModifier,
1.0; !- Ground Reflected Solar Modifier
eio output
! <Site:GroundReflectance:SnowModifier>, Normal, Daylighting {dimensionless}
Site:GroundReflectance:SnowModifier, 1.000, 0.000
! <Site:GroundReflectance:Snow>,Jan{dimensionless},Feb{dimensionless},Mar{dimensionless},Apr{dimensionless},May{dimensionless},Jun{dimensionless},Jul{dimensionless},Aug{dimensionless},Sep{dimensionless},Oct{dimensionless},Nov{dimensionless},Dec{dimensionless}
Site:GroundReflectance:Snow, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20, 0.20
! <Site:GroundReflectance:Snow:Daylighting>,Jan{dimensionless},Feb{dimensionless},Mar{dimensionless},Apr{dimensionless},May{dimensionless},Jun{dimensionless},Jul{dimensionless},Aug{dimensionless},Sep{dimensionless},Oct{dimensionless},Nov{dimensionless},Dec{dimensionless}
Site:GroundReflectance:Snow:Daylighting, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00
This results in reduced daylighting illuminance whenever the snow (on the ground) flag is true. This likely has minimal impact since most winter design days are run without solar, and most epw files have zeroes for snow depth.
Details
Some additional details for this issue (if relevant):
- Version of EnergyPlus 23.2
- Revealed by Fill object defaults for blank or missing fields and fix Site:GroundReflectance:SnowModifier defaults #10295
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
-
Defect file WindowTests.idf and
WindowTests-DDaysWithSunAndSnow.idf.txt -
Ticket added to Pivotal for defect (development team task)
-
Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)