Bug: pkgdown warnings and tibble print formatting issue #1012#1087
Conversation
7390423 to
bab11dd
Compare
e-perl-NOAA
left a comment
There was a problem hiding this comment.
Thanks for running point and submitting the PR for these changes!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
===========================================
+ Coverage 70.58% 85.96% +15.37%
===========================================
Files 52 81 +29
Lines 1914 7887 +5973
Branches 517 513 -4
===========================================
+ Hits 1351 6780 +5429
- Misses 532 1096 +564
+ Partials 31 11 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kellijohnson-NOAA
left a comment
There was a problem hiding this comment.
Thank you for this! The edits are great. I have a few minor comments below. I also think that we need to run this through the linter, which you can do by calling the slash command.
One major question that I have is because we are fixing things, should we open this PR to main instead of dev? I know that this is not typical but we have a few changes in main already that we are going to release as a hot fix and I am leaning towards including these changes in that release rather than waiting for the next release. Please let me know your thoughts and sorry that I did not voice this earlier in the process.
|
@kellijohnson-NOAA Will do! I’ll work through the comments and updated the PR to main. Thanks for taking the time to review it |
|
@awilnoaa I reran the failed actions because when looking through the logs it seemed like more of an issue on github actions end then ours, which it was! |
|
@e-perl-NOAA Thank you, glad it turned out to be a GitHub issue! |
a130f2f to
b660cae
Compare
kellijohnson-NOAA
left a comment
There was a problem hiding this comment.
Thanks Adrianne for these changes. I am going to remove the space after Developer and then once they pass everything I will merge it into main.
…warnings - Remove stray ANSI color prefixes from printed tibble output using withr - Add missing fig.alt text to vignettes flagged by pkgdown - Remove unused section icons from pkgdown config (icons only render in navbar)
b660cae to
f148f75
Compare
What is the feature?
How have you implemented the solution?
withr.Does the PR impact any other area of the project, maybe another repo?
#1012