Fix boxing for registration of builtin condition methods #5970

snakefoot · 2025-08-21T18:43:09Z

No description provided.

coderabbitai · 2025-08-21T18:43:18Z

Walkthrough

Condition lambdas for string comparisons now return boxed ConditionExpression values instead of raw booleans across equals/strequals/contains/starts-with/ends-with (2- and 3-parameter variants). The 3-parameter forms retain ignoreCase handling. Both the source file and its T4 template were updated; no public signatures changed.

Changes

Cohort / File(s)	Summary
Condition registration boxing (source) `src/NLog/Config/AssemblyExtensionTypes.cs`	Updated condition registrations to return ConditionExpression.BoxedTrue/BoxedFalse instead of bool for equals, strequals, contains, starts-with, ends-with (2- and 3-arg). Logic and parameter validation unchanged.
Template update for code generation `src/NLog/Config/AssemblyExtensionTypes.tt`	Mirrored boxing change in T4 template so generated registrations produce boxed ConditionExpression results; preserved existing ignoreCase handling and structure.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Logger as Logger
  participant Cond as Condition Lambda
  participant Methods as ConditionMethods
  participant Expr as ConditionExpression

  Logger->>Cond: Evaluate condition(logEvent, args)
  Cond->>Methods: equals/strequals/contains/starts/ends(...)
  Methods-->>Cond: bool result
  alt result == true
    Cond-->>Expr: BoxedTrue
  else result == false
    Cond-->>Expr: BoxedFalse
  end
  Expr-->>Logger: ConditionExpression (boxed)
  note over Cond,Expr: 3-arg forms keep ignoreCase behavior unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A whisker-twitch, a tidy tune,
We box our truths in silver rune.
Equals hum, and starts-with sings,
Ends-with nods with gentle wings.
Case ignored? We still profess—
A boxed yes/no, no more, no less. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-08-21T18:53:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (2)

src/NLog/Config/AssemblyExtensionTypes.cs (1)

392-392: Add unit tests to lock in the boxing behavior across all operators.

Recommend adding tests that assert the returned objects are the canonical boxed instances. This guards against accidental re-introduction of raw bool boxing.

Example outline:

For each of equals/strequals/contains/starts-with/ends-with (2- and 3-param variants), invoke via ConditionMethodFactory and assert ReferenceEquals(result, NLog.Conditions.ConditionExpression.BoxedTrue/False).

If helpful, I can draft these tests.

Also applies to: 400-402, 405-407, 410-412
src/NLog/Config/AssemblyExtensionTypes.tt (1)
253-253: Optional: DRY the boxing pattern in T4 to reduce repetition.

To make future edits safer, consider a small T4 helper like Box(boolExpr) that emits the ternary with the fully-qualified constants.

Example:
<#+
    string BoxBool(string expr) =>
        $"{expr} ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse";
#>
Then use:
factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => <#= BoxBool("NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString())") #>);
Also applies to: 256-258, 261-263, 266-268, 271-273

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0de74a0 and f76cce2.

📒 Files selected for processing (2)

src/NLog/Config/AssemblyExtensionTypes.cs (1 hunks)
src/NLog/Config/AssemblyExtensionTypes.tt (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/NLog/Config/AssemblyExtensionTypes.cs (3)

src/NLog/Config/MethodFactory.cs (3)

RegisterTwoParameters (322-330)

CheckTypeAliasExists (110-110)

RegisterThreeParameters (332-340)

src/NLog/Conditions/ConditionMethods.cs (1)

ConditionMethods (43-120)

src/NLog/Config/Factory.cs (1)

CheckTypeAliasExists (85-85)

🔇 Additional comments (4)

src/NLog/Config/AssemblyExtensionTypes.cs (2)
392-392: Good change: removes per-evaluation boxing allocations.

Returning ConditionExpression.BoxedTrue/BoxedFalse matches the Func<..., object?> signature expected by MethodFactory and avoids creating new boxed bools on each evaluation. This should cut GC pressure in hot condition paths.

Also applies to: 395-397, 400-402, 405-407, 410-412

395-397: Verify strequals third-parameter default fallback

The Equals2 method in ConditionMethods is marked with [DefaultParameterValue(false)], yet our RegisterThreeParameters("strequals", …) logic falls back to true when arg3 isn’t a bool. This mismatch means an expression like strequals(a, b, "false") would unexpectedly behave as case-insensitive. If this was an intentional choice for back-compat, no change is needed; otherwise, consider defaulting to false to align with the method’s attribute.

• Location: src/NLog/Config/AssemblyExtensionTypes.cs (lines 395–397)
• Current code:
factory.GetConditionMethodFactory()
       .RegisterThreeParameters("strequals",
           (logEvent, arg1, arg2, arg3) =>
               NLog.Conditions.ConditionMethods.Equals2(
                   arg1?.ToString(),
                   arg2?.ToString(),
                   arg3 is bool ignoreCase ? ignoreCase : true)
               ? Conditions.ConditionExpression.BoxedTrue
               : Conditions.ConditionExpression.BoxedFalse);
• Optional refactor to match [DefaultParameterValue(false)]:
- arg3 is bool ignoreCase ? ignoreCase : true
+ arg3 is bool ignoreCase ? ignoreCase : false
Please verify whether the current true fallback is intentional for backward compatibility or if it should be changed to false.
src/NLog/Config/AssemblyExtensionTypes.tt (2)

253-253: Nice allocation win baked into the generator.

Baking the boxing optimization into the .tt keeps the generated code consistent and prevents future regressions.

Also applies to: 256-258, 261-263, 266-268, 271-273

253-253: All condition registrations correctly use canonical BoxedTrue/BoxedFalse constants

Verified that for all “equals”, “strequals”, “contains”, “starts-with”, and “ends-with” registrations—across both the T4 template (AssemblyExtensionTypes.tt) and the generated C# output (AssemblyExtensionTypes.cs)—the methods consistently use Conditions.ConditionExpression.BoxedTrue and Conditions.ConditionExpression.BoxedFalse, with no raw true/false literals remaining. The optional alias check also found no unintended using Conditions = directives.

coderabbitai · 2025-08-21T19:19:20Z

src/NLog/Config/AssemblyExtensionTypes.cs

                factory.GetConditionMethodFactory().RegisterOneParameter("length", (logEvent, arg1) => NLog.Conditions.ConditionMethods.Length(arg1?.ToString()));
            if (skipCheckExists || !factory.GetConditionMethodFactory().CheckTypeAliasExists("equals"))
-                factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()));
+                factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse);


🛠️ Refactor suggestion

Use fully-qualified NLog.Conditions.ConditionExpression (avoid relying on a missing alias).

These lambdas reference Conditions.ConditionExpression.BoxedTrue/BoxedFalse. There’s no using Conditions = NLog.Conditions; (nor an obvious global alias) in this file, while other calls here use the full NLog.Conditions.* qualification. This will fail to compile unless a project-wide alias exists. Recommend fully-qualifying to NLog.Conditions.ConditionExpression for consistency and safety.

Apply this diff:

- factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("strequals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("strequals", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("strequals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("strequals", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("contains", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("contains", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("contains", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("contains", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("starts-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("starts-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("starts-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("starts-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("ends-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("ends-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("ends-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("ends-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse);

Also applies to: 395-397, 400-402, 405-407, 410-412

🤖 Prompt for AI Agents

In src/NLog/Config/AssemblyExtensionTypes.cs around lines 392 (and similarly 395-397, 400-402, 405-407, 410-412), the lambda expressions use Conditions.ConditionExpression.BoxedTrue/BoxedFalse without a local alias for Conditions which can break compilation; update each occurrence to use the fully-qualified NLog.Conditions.ConditionExpression.BoxedTrue and NLog.Conditions.ConditionExpression.BoxedFalse so they match the surrounding code and avoid relying on a project-wide alias.

coderabbitai · 2025-08-21T19:19:20Z

src/NLog/Config/AssemblyExtensionTypes.tt

                factory.GetConditionMethodFactory().RegisterOneParameter("length", (logEvent, arg1) => NLog.Conditions.ConditionMethods.Length(arg1?.ToString()));
            if (skipCheckExists || !factory.GetConditionMethodFactory().CheckTypeAliasExists("equals"))
-                factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()));
+                factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse);


🛠️ Refactor suggestion

Template should also fully-qualify ConditionExpression to avoid alias dependency.

Same concern as in the generated .cs: prefer NLog.Conditions.ConditionExpression to Conditions.ConditionExpression to prevent compile-time resolution issues if no alias exists. Keeping the T4 authoritative prevents future regressions.

Apply this diff:

- factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("equals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("strequals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("strequals", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("strequals", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("strequals", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Equals2(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("contains", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("contains", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("contains", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("contains", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.Contains(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("starts-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("starts-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("starts-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("starts-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.StartsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterTwoParameters("ends-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString()) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); - factory.GetConditionMethodFactory().RegisterThreeParameters("ends-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? Conditions.ConditionExpression.BoxedTrue : Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterTwoParameters("ends-with", (logEvent, arg1, arg2) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString()) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse); + factory.GetConditionMethodFactory().RegisterThreeParameters("ends-with", (logEvent, arg1, arg2, arg3) => NLog.Conditions.ConditionMethods.EndsWith(arg1?.ToString(), arg2?.ToString(), arg3 is bool ignoreCase ? ignoreCase : true) ? NLog.Conditions.ConditionExpression.BoxedTrue : NLog.Conditions.ConditionExpression.BoxedFalse);

Also applies to: 256-258, 261-263, 266-268, 271-273

🤖 Prompt for AI Agents

In src/NLog/Config/AssemblyExtensionTypes.tt around lines 253 (and similarly at 256-258, 261-263, 266-268, 271-273), the generated template uses the short alias Conditions.ConditionExpression; update each occurrence to use the full type name NLog.Conditions.ConditionExpression (e.g., replace Conditions.ConditionExpression.BoxedTrue/BoxedFalse with NLog.Conditions.ConditionExpression.BoxedTrue/BoxedFalse) so the generated .cs files do not rely on a using alias and will compile even if the alias is absent.

Fix boxing for registration of builtin condition methods

f76cce2

pull-request-size bot added the size/M label Aug 21, 2025

coderabbitai bot reviewed Aug 21, 2025

View reviewed changes

snakefoot enabled auto-merge (squash) August 21, 2025 19:22

snakefoot added the performance label Aug 21, 2025

snakefoot merged commit 2e91281 into NLog:dev Aug 21, 2025
6 checks passed

snakefoot added this to the 6.0.4 milestone Aug 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix boxing for registration of builtin condition methods #5970

Fix boxing for registration of builtin condition methods #5970

Uh oh!

snakefoot commented Aug 21, 2025

Uh oh!

coderabbitai bot commented Aug 21, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

sonarqubecloud bot commented Aug 21, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Aug 21, 2025

Uh oh!

coderabbitai bot Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Fix boxing for registration of builtin condition methods #5970

Fix boxing for registration of builtin condition methods #5970

Uh oh!

Conversation

snakefoot commented Aug 21, 2025

Uh oh!

coderabbitai bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

sonarqubecloud bot commented Aug 21, 2025

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Aug 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)