NLog.Targets.Network nuget-package links #5953
Conversation
WalkthroughThe project file for the NLog.Targets.Network package was updated to expand the release notes section. Additional documentation links for related targets and a layout renderer were added, and the formatting was adjusted for clarity. In the unit test assembly info, two code analysis suppression attributes were added to avoid specific warnings, with justifications. A test method in the ConcurrentFileTargetTests was modified to move an assertion after clearing the LogManager configuration and made it conditional. No other code, functional, or structural changes were made. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/NLog.Targets.Network/NLog.Targets.Network.csproj (1)
18-35: Consider formatting for NuGet Gallery readabilitySome NuGet UIs collapse consecutive line-feeds, resulting in a wall of text. Using either bullets (
•) or HTML<br/>tags can make each link clearly separated regardless of the client:-NetworkTarget Docs: -https://github.com/NLog/NLog/wiki/Network-target - -SyslogTarget Docs: -https://github.com/NLog/NLog/wiki/Syslog-target +• NetworkTarget + https://github.com/NLog/NLog/wiki/Network-target +<br/> +• SyslogTarget + https://github.com/NLog/NLog/wiki/Syslog-target ...Purely cosmetic, feel free to ignore if your preferred NuGet front-end already renders this nicely.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/NLog.Targets.Network/NLog.Targets.Network.csproj(1 hunks)
🔇 Additional comments (1)
src/NLog.Targets.Network/NLog.Targets.Network.csproj (1)
18-35: Comprehensive links in release notes look goodThe added links give users quick access to documentation for all related targets and the layout renderer. No functional impact and the NuGet client will accept multi-line text. Nice improvement.
ae13546 to
9afb5ea
Compare
Pull request was closed
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/NLog.Targets.ConcurrentFile.Tests/ConcurrentFileTargetTests.cs (1)
445-445: Nit: swap Assert.Equal args to expected, actualFor clearer failure messages in xUnit, consider
Assert.Equal(fileOpenList.Count, fileTarget.OpenFileCacheSize);(expected, actual).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/NLog.Targets.Network/NLog.Targets.Network.csproj(1 hunks)tests/NLog.Targets.ConcurrentFile.Tests/ConcurrentFileTargetTests.cs(1 hunks)tests/NLog.UnitTests/Properties/AssemblyInfo.cs(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/NLog.Targets.Network/NLog.Targets.Network.csproj
🚧 Files skipped from review as they are similar to previous changes (1)
- tests/NLog.UnitTests/Properties/AssemblyInfo.cs
🔇 Additional comments (1)
tests/NLog.Targets.ConcurrentFile.Tests/ConcurrentFileTargetTests.cs (1)
444-446: Good fix: assert after flushing/closing to avoid false positivesMoving the assertion after
LogManager.Configuration = nullensures files are flushed/closed before validating open-file cache expectations. This reduces flakiness.
|
No description provided.