Implement IRawValue on ${whenEmpty}#3395
Closed
304NotModified wants to merge 1 commit intorelease/4.6.4from
Closed
Implement IRawValue on ${whenEmpty}#3395304NotModified wants to merge 1 commit intorelease/4.6.4from
304NotModified wants to merge 1 commit intorelease/4.6.4from
Conversation
Member
Author
|
@snakefoot could you please help me getting this ready? I doesn't work unfortunately, probably because Any idea how to fix that? Also think this isn't the most efficient way, but dunno how to write a more efficient test. public bool TryGetRawValue(LogEventInfo logEvent, out object value)
{
var item = Inner.Render(logEvent);
if (item.Length > 0)
...
} |
Contributor
|
Don't do this:
Instead check if the raw-value-returned is null or empty-string. |
Contributor
|
Created #3398 |
Member
Author
|
Syoer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #3372
related: #3373 and #3139