Skip to content

AsyncTaskTarget_TestThrottleOnTaskDelay - More logging and increase treshold#3279

Merged
repo-ranger[bot] merged 1 commit intoNLog:devfrom
snakefoot:AsyncTaskTarget_TestThrottleOnTaskDelayFix
Apr 5, 2019
Merged

AsyncTaskTarget_TestThrottleOnTaskDelay - More logging and increase treshold#3279
repo-ranger[bot] merged 1 commit intoNLog:devfrom
snakefoot:AsyncTaskTarget_TestThrottleOnTaskDelayFix

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

Trying to resolve #3277

@304NotModified
Copy link
Copy Markdown
Member

thanks! Would be great to get the build more stable. Restarting is now almost a daily task..

@304NotModified
Copy link
Copy Markdown
Member

would another option to call FlushAsync and use the AsyncContinuation.WaitOne?

@snakefoot
Copy link
Copy Markdown
Contributor Author

The test ensures that the target performs correctly without doing explicit flushes.

@304NotModified
Copy link
Copy Markdown
Member

ok good one :)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3279 into dev will increase coverage by <1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev   #3279    +/-   ##
======================================
+ Coverage     80%     80%   +<1%     
======================================
  Files        355     356     +1     
  Lines      28002   28007     +5     
  Branches    3728    3728            
======================================
+ Hits       22340   22393    +53     
+ Misses      4583    4537    -46     
+ Partials    1079    1077     -2

@repo-ranger repo-ranger bot merged commit b83dde5 into NLog:dev Apr 5, 2019
@snakefoot snakefoot deleted the AsyncTaskTarget_TestThrottleOnTaskDelayFix branch April 4, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unstable test NLog.UnitTests.Targets.AsyncTaskTargetTest.AsyncTaskTarget_TestThrottleOnTaskDelay

2 participants