SonarLint and CodeFactor warning reduction + better internal logging#3263
Merged
304NotModified merged 1 commit intoNLog:devfrom Apr 3, 2019
Merged
Conversation
Member
|
FYI
|
9904e34 to
40c935a
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3263 +/- ##
======================================
- Coverage 80% 80% -<1%
======================================
Files 355 355
Lines 27986 27989 +3
Branches 3727 3727
======================================
- Hits 22324 22317 -7
- Misses 4579 4593 +14
+ Partials 1083 1079 -4 |
Member
|
@snakefoot thanks for doing refactorings 👍 FYI: I really like this site, which has some nice lists how to refactor things: https://sourcemaking.com/refactoring |
40c935a to
7e47071
Compare
| dict[configItem.Key.Trim()] = configItem.Value; | ||
| string key = configItem.Key.Trim(); | ||
| if (dict.ContainsKey(key)) | ||
| { |
Member
There was a problem hiding this comment.
This is something else than the refactor, isn't?
Member
There was a problem hiding this comment.
Are there more of these changes in this PR?
Contributor
Author
There was a problem hiding this comment.
Yes some debug-noise to help diagnose Xml-config issues.
304NotModified
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.