StringBuilderPool - Allow FastPool-object to have larger capacity, but remember to reset (#3345)

snakefoot · 304NotModified · commit f8f7414d34d6 · 2019-04-29T21:03:36.000+02:00
diff --git a/src/NLog/Internal/StringBuilderPool.cs b/src/NLog/Internal/StringBuilderPool.cs
@@ -99,12 +99,10 @@ private void Release(StringBuilder stringBuilder, int poolIndex)
                 {
                     stringBuilder = new StringBuilder(maxBuilderCapacity / 2);
                 }
-            } 
-            else
-            {
-                stringBuilder.Length = 0;
             }
 
+            stringBuilder.Length = 0;
+
             if (poolIndex == -1)
             {
                 _fastPool = stringBuilder;

Original file line number	Diff line number	Diff line change
`@@ -99,12 +99,10 @@ private void Release(StringBuilder stringBuilder, int poolIndex)`
`99`	`99`	`{`
`100`	`100`	`stringBuilder = new StringBuilder(maxBuilderCapacity / 2);`
`101`	`101`	`}`
`102`		`- }`
`103`		`- else`
`104`		`- {`
`105`		`- stringBuilder.Length = 0;`
`106`	`102`	`}`
`107`	`103`
	`104`	`+ stringBuilder.Length = 0;`
	`105`	`+`
`108`	`106`	`if (poolIndex == -1)`
`109`	`107`	`{`
`110`	`108`	`_fastPool = stringBuilder;`