Support edge_size parameter in ngt_search_index_as_float#189
Merged
masajiro merged 3 commits intoNGT-labs:mainfrom Feb 20, 2026
Merged
Support edge_size parameter in ngt_search_index_as_float#189masajiro merged 3 commits intoNGT-labs:mainfrom
edge_size parameter in ngt_search_index_as_float#189masajiro merged 3 commits intoNGT-labs:mainfrom
Conversation
Matts966
commented
Feb 19, 2026
| } | ||
| #ifndef NGT_SHARED_MEMORY_ALLOCATOR | ||
| void save(std::string indexPath) { saveIndex(indexPath); } | ||
| void save(std::string &indexPath) { saveIndex(indexPath); } |
Member
Author
There was a problem hiding this comment.
This change (call by reference) is requested by @kmrmt for Rust usage 🙏
2b633f7 to
4b4d695
Compare
39d9c38 to
89b79c0
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR supports
edge_sizeparameter inngt_search_index_as_floatto search vector with dynamicedge_size.This feature is requested by users of Vald.