Changes to facilitate CFA in cf-python #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
Just some typos from recent commits to blitz.
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
A few more from a new commit, before I approve the PR overall!
sadielbartholomew
approved these changes
Apr 18, 2023
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
Thanks for addressing all of my feedback. I've done a quick sanity check that everything still functions as it should after the new commits, with the full cfdm test suite still passing locally. I think black formatting requires one trivial change to be satisfied, namely:
diff --git a/cfdm/read_write/netcdf/netcdfread.py b/cfdm/read_write/netcdf/netcdfread.py
index c1ea1a78f..8817ccbba 100644
--- a/cfdm/read_write/netcdf/netcdfread.py
+++ b/cfdm/read_write/netcdf/netcdfread.py
@@ -5474,7 +5474,6 @@ class NetCDFRead(IORead):
"calendar"
)
-
# Store the missing value indicators
missing_values = {}
for attr in (and there's my two new typo fixes to include, but once those minor changes are made I am happy, so please make those and then merge!
Contributor
Author
|
Great, thanks Sadie. Typos merges and blank line removed. Merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed off-line, these changes facilitate CFA in cf-python, implemented in NCAS-CMS/cf-python#630, but do not change the API or functionality of cfdm.
Edit 2023-04-17: Notes on changes:
varidin favour ofaddress; updatedopenmethod (that allows for multiple files); new "groups" API._._customize_auxiliary_coordinatesand_customize_field_ancillariesmethods for use by cf-python; Accounted for NetCDFArray API changes._customize_createVariable(needed by cf-python); Generally passing round more info so that cf-python can pick up on it.