Subsampled coordinates (1) and compression refactor #168
Conversation
…l/cfdm into subsampled-coordinates
…ampled-coordinates
… into subsampled-coordinates
cfdm/data/subarray/mixin/biquadraticlatitudelongitudeinterpolation.py
Outdated
Show resolved
Hide resolved
sadielbartholomew
left a comment
There was a problem hiding this comment.
Final comments! All previous feedback has been addressed really well, so this is very nearly ready to merge in my eyes.
cfdm/test/test_subsampling.py
Outdated
| ) | ||
| ) | ||
|
|
||
| @unittest.skipIf(True, "awaiting test file") |
There was a problem hiding this comment.
Was this meant to be un-skipped before this PR was opened / went in (I imagine so as it's the only test in the test suite with a skip on this branch)? It guess the test needs adapting somehow (from those "change" values)...
There was a problem hiding this comment.
I'd forgotten about this. I am still awaiting said test file from Anders and will chase it up. If it's not forthcoming I'll have to make one myself.
There was a problem hiding this comment.
Thanks for clarifying. That's fine. Maybe you could either add a TODO marker there or open a GitHub Issue about this so it doesn't get forgotten about?
…cfdm into compression-refactor
Wow. Thank you so much for your marathon review 🎆 ! Let's hold off merging in case the missing test file can be procured quickly - hopefully it won't expose something nasty ... |
|
Still awaiting a test file for the Master will now become |
Fixes #167