New keyword parameter to cf.histogram: density
#795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wanting a review, @davidhassell? |
Collaborator
Author
|
Thanks, but I think Jonathan's got this one covered :) |
Collaborator
JonathanGregory
left a comment
There was a problem hiding this comment.
Thanks, David. I think it's fine, as far as I can tell. Is "out.override_units(Units(), inplace=True)" deleting the units? If so, I don't think you need to, or should - they're probably correct. The pdf from a temperature histogram, for example, has units of K-1.
Collaborator
Author
|
Good point on the units - I'll fix that. |
Collaborator
Author
|
@JonathanGregory, is this better: 8e5487f ? |
JonathanGregory
approved these changes
Jul 17, 2024
Collaborator
JonathanGregory
left a comment
There was a problem hiding this comment.
Yes, I think the units are fine now. Thanks.
Member
Oops sorry David, I missed that part somehow and thought you'd forgot to assign anyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #794