Allow DSG tractories with identical trajectory_id values to be aggregated
#724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi David, I am in the middle of a meeting but afterwards I will complete my review. I noticed before that I messed up the one trivial conflict resolution for the change log, sorry (one entry was appearing at the top and bottom of the list and I didn't notice) - all that is needed is to remove one duplicated entry from another PR, so I will push up another commit to do that after the meeting. |
sadielbartholomew
approved these changes
Feb 28, 2024
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
Excellent. I've raised a pair of very minor comments but once you've considered those, please merge.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
approved these changes
Feb 28, 2024
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
Just to confirm, all feedback addressed as far as I am concerned so please merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723
Needs NCAS-CMS/cfdm#290 for the new test to work.
Full fix also needs #730