Skip to content

Conversation

@davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Apr 28, 2023

Deprecates cf.relative_vorticity, and allows cf.Field.laplacian_xy, cf.Field.grad_xy, cf.curl_xy and cf.div_xy to work in cases when the dimension coordinates are missing standard names.

@davidhassell davidhassell added this to the 3.15.1 milestone Apr 28, 2023
@davidhassell davidhassell changed the title Relative vorticity Deprecate cf.relative_vorticity Apr 28, 2023
@davidhassell
Copy link
Collaborator Author

Hi @bewithankit: extra changes: 0562abc

@sadielbartholomew
Copy link
Member

Out of interest, why is cf.relative_vorticity being deprecated?

@davidhassell
Copy link
Collaborator Author

davidhassell commented Apr 28, 2023

Hi Sadie - (following our chat), we decided to not fix it nor alias it to curl_xy because its spherical polar coordinate fomula was wrong (well, it was an approximation rather than an exact formula), and its API was different to curl_xy, so aliasing it was not straight forward.

Copy link
Contributor

@bewithankit bewithankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David, Thank you for the changes! Looks all good, merge when ready!

@davidhassell davidhassell merged commit 7a742f2 into NCAS-CMS:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants