Skip to content

Conversation

@davidhassell
Copy link
Collaborator

Fixes #626

@davidhassell davidhassell added this to the 3.14.2 milestone Mar 29, 2023
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the approach to fix the underlying issue by clearing the inappropriately-inherited properties on the bounds. Fix tested as working locally and via the CI (the few failing jobs are failing on setup issues I shall address elsewhere soon).

I would therefore approve this, but feel I must encourage us to add a test to capture the bug before supporting a merge! If there's good enough reason to skip some new testing along those lines, then fair enough, but do provide a little bit of justification. Then, either way, I'll pop the approval up. Thanks.

@davidhassell
Copy link
Collaborator Author

New test for bounds properties: 4f3edbb

@davidhassell
Copy link
Collaborator Author

@sadielbartholomew - over to you for sign off on the test method docstrings.

@davidhassell davidhassell merged commit a5ff9c9 into NCAS-CMS:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bounds of computed vertical coordinates retain incorrect properties

2 participants