-
Notifications
You must be signed in to change notification settings - Fork 23
LAMA to Dask: misc. fixes for a passing test_aggregate
#572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMA to Dask: misc. fixes for a passing test_aggregate
#572
Conversation
|
@davidhassell please either hold on the reviewing here until tomorrow morning, or you can partially review under the following context:
If you like you could review the commits here standalone noting the above, with the main one is the initial tweak to fix an aspect of |
Co-authored-by: David Hassell <david.hassell@ncas.ac.uk>
|
Thanks for all of your invaluable guidance here @davidhassell. (I manually added you as a co-author on the new fix approach commit, since you essentially wrote that code!) This is good to review now, I think. FYI, the linting CI job is failing due to steup issues relating to GitLab (I see these on the command line too, so think it will resolve itself in time and will ignore it for now). So we can ignore that. |
davidhassell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. All makes sense following our conversations.
Towards #182, confirms that
cf.aggregateworks under the new "Dask way" with no modifications, withtest_basic_aggregatefailing instead due to specific issues elsewhere, namely:Data.equals;an issue with construct comparison leading to field copies not being recognised as equal.(Note to tidy up previous investigation/debugging branches, I created a fresh branch and re-applied commits to break down the fixes to specific parts.)