dask: Field.argmax
#557
Merged
dask: Field.argmax
#557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I haven't been assigned to this but assume you want me to review it (after the regridding PR) @davidhassell, so will self-assign. Unassign me if I'm wrong, and note some conflicts need to be resolve. Thanks. |
sadielbartholomew
approved these changes
Jan 30, 2023
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
I've raised a few minor comments but overall this is all good. Please merge when ready.
One quick question, also: why do we have an argmax but not argmin method on both Data and Field? Seems weird to me to have one and not both...
Collaborator
Author
|
Hi Sadie - there's no See: #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.