dask: Data.cull_graph, concatenate and Field.collapse
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2022
Data.cull_graph, concateante and Field.collapseData.cull_graph, concatenate and Field.collapse
sadielbartholomew
approved these changes
Jan 26, 2023
sadielbartholomew
approved these changes
Jan 27, 2023
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
(Pressed 'approve' pre-maturely, sorry - one more comment to add.)
Overall, achieves the aims listed in the opening comment and results in passing collapse-related tests (at least for me locally) as promised. I've included some questions and minor comments, but this is ready to merge once you've considered them in my eyes. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
test_Field_collapseintest_FIeld.py, andtest_collapse.py.data._parse_weights._preservekeywords.scalekeyword toField.collapse. This wasn't necessary, but at one stage I though it might solve some problems. Left it in because it's nicer and more efficient.Forward ports dask: Reinstate netCDF lock #531 to prove that it stops the seg faults.Edit 2023-01-03: dask: Reinstate netCDF lock #531 has now been accepted intolama-to-daskand pulled in to here from there.