Skip to content

Fix DimensionCoordinate.create_bounds for cyclic coordinates & improve docs #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidhassell merged 12 commits into from
Dec 20, 2022
Merged

Fix DimensionCoordinate.create_bounds for cyclic coordinates & improve docs #523

davidhassell merged 12 commits into from
Dec 20, 2022

Conversation

@davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Dec 13, 2022

Fixes #514

@davidhassell davidhassell added this to the 3.14.0 milestone Dec 13, 2022
sadielbartholomew
sadielbartholomew approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed as a logical fix for the bug with a very thorough and clear update to the docstring 💯. I've highlighted some typos (and asked one random question) but other than those this is good to merge in my eyes. Thanks.

davidhassell and others added 7 commits December 20, 2022 16:03
@davidhassell @sadielbartholomew
Typo
2913dbd 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Docs
9fac82c 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
ea17eb9 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
d81e9aa 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
f481f9e 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
0bc40ae 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
06fac4a 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell davidhassell merged commit 741d611 into NCAS-CMS:master Dec 20, 2022
@davidhassell davidhassell deleted the create-bounds-docs branch December 20, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

No one assigned

Labels

low priority

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

Incorrect Voronoi bounds from DimensionCoordinate.create_bounds for cyclic coordinates

2 participants

@davidhassell @sadielbartholomew