dask: Correctly read VLEN string variables #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Dec 14, 2022
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
but new change reuses code from cfdm, rather than cutting and pasting, which has to be better!
Definitely better!
This allows test_groups.py to pass.
This passes locally for me. All the changes look sensible. I've raised a few minor comments but otherwise this is good to merge in my eyes so please go ahead when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for incorrect reading of VLEN string variables from netCDF4 files. I don't know why this was failing, but new change reuses code from cfdm, rather than cutting and pasting, which has to be better! This allows
test_groups.pyto pass.Need NCAS-CMS/cfdm#235 to be merged first. Edit: which has now happened