Skip to content

dask: Deprecate close #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidhassell merged 8 commits into from
Dec 6, 2022
Merged

dask: Deprecate close #504

davidhassell merged 8 commits into from
Dec 6, 2022

Conversation

@davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Nov 22, 2022

Deprecates close methods, and removes the corresponding tests.

@davidhassell davidhassell added low priority dask Relating to the use of Dask labels Nov 22, 2022
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 22, 2022
@davidhassell davidhassell mentioned this pull request Nov 22, 2022
Closed
sadielbartholomew
sadielbartholomew reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close, but no cigar! 😆 Feel free to apply the recurrent change suggested yourself rather than via my 'suggestion' set if that's more convenient, but I've made them as suggestions in case that is simplest.

Is there a location we can put some brief testing on deprecated keywords such as this, since nothing failed in the test suite despite the consistent invalid keyword argument here, and it would be good to catch basic issues like that?

sadielbartholomew
sadielbartholomew requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Intended to set this as my judgement in the review I just submitted...]

davidhassell and others added 7 commits December 6, 2022 09:19
@davidhassell @sadielbartholomew
Typo
a9d9059 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
1291cb9 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
94c47f8 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
9e91d37 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
9f92d23 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
d592df8 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
9e88c47 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

davidhassell commented Dec 6, 2022

Is there a location we can put some brief testing on deprecated keywords such as this, since nothing failed in the test suite despite the consistent invalid keyword argument here, and it would be good to catch basic issues like that?

Hi Sadie, good idea. Not yet - I suppose a new file test_deprecated.py might be a good place to put them, from where they can easily be deleted once the removed_at version is reached.

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Dec 6, 2022

I suppose a new file test_deprecated.py might be a good place to put them, from where they can easily be deleted once the removed_at version is reached.

Sounds like a good plan to me. Shall we bump it to a new issue, since the Dask migration takes priority I am sure?

@davidhassell
Copy link
Collaborator Author

davidhassell commented Dec 6, 2022

Shall we bump it to a new issue, since the Dask migration takes priority I am sure?
Agreed - I'll make one.

Is this good to merge, now?

sadielbartholomew
sadielbartholomew approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback all addressed. All good now, please merge.

@davidhassell davidhassell merged commit 669b719 into NCAS-CMS:lama-to-dask Dec 6, 2022
@davidhassell davidhassell deleted the dask-close-2 branch December 6, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

No one assigned

Labels

dask Relating to the use of Dask low priority

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhassell @sadielbartholomew