dask: Subsampled compression #502
Conversation
sadielbartholomew
left a comment
There was a problem hiding this comment.
I've raised one question and a few minor comments, so please check those out, but this is all good. Please merge when ready.
| ) | ||
| ) | ||
|
|
||
| @unittest.skipIf(True, "TODO: awaiting test file") |
There was a problem hiding this comment.
Any news on when this test file might become available? I seem to recall (for the cfdm case, I guess the same file will be used for both libraries) you asked someone to provide something for this specific case and were waiting on that (though that could be my memory going wrong)?
There was a problem hiding this comment.
Ah yes - still waiting, although I have been in touch. I'll chase it up again ...
There was a problem hiding this comment.
Thanks for clarifying. Obviously it would be good to not leave it too long else it might fall off our radar and then never get tested overall...
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Small fixes to allow
test_subsampling.pyto pass, that essentially just forward port a few things from cfdm.