dask: Data.isscalar
#395
Merged
dask: Data.isscalar
#395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
May 6, 2022
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
All good. One question posed, so please merge if you don't think that calls for any changes, otherwise we can discuss the particulars.
Merged
sadielbartholomew
approved these changes
May 9, 2022
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
All good to merge, thanks.
(In reviewing the final commit I did notice there is a format-string issue in the deprecation messaging which imagine was missed from a recent PR touching the deprecation module, but I will blitz a commit to fix that separately:
DeprecationError: Data attribute 'isscalar' has been deprecated at version TODODASK and will be removed at version and will be removed at version 5.0.0. Use 'd.ndim == 0' instead)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.