Skip to content

dask: Data.compressed #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidhassell merged 5 commits into from
Apr 20, 2022
Merged

dask: Data.compressed #383

davidhassell merged 5 commits into from
Apr 20, 2022

Conversation

@davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Apr 19, 2022

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Apr 19, 2022
@davidhassell davidhassell mentioned this pull request Apr 19, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent: an elegant dask solution with robust updates to the unit test. There's one test line that seems superfluous, but overall this is good to merge (once the conflicts are resolved).

@davidhassell davidhassell merged commit cdea366 into NCAS-CMS:lama-to-dask Apr 20, 2022
@davidhassell davidhassell deleted the dask-compressed branch November 15, 2022 09:21
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

No one assigned

Labels

dask Relating to the use of Dask

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhassell @sadielbartholomew