Skip to content

Conversation

@davidhassell
Copy link
Collaborator

The masked_as_zero keyword has been deprecated because the person who requested it originally a) hasn't ever used it, b) says he doesn't need it and c) I think that its functionality was a bit confused. So, all in all I hope we can make this API change without any worries.

@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 8, 2022
@sadielbartholomew
Copy link
Member

The masked_as_zero keyword has been deprecated because the person who requested it originally a) hasn't ever used it, b) says he doesn't need it and c) I think that its functionality was a bit confused.

😞 Sad to hear, but fair enough. Thanks for the context.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All great, please merge.

@davidhassell davidhassell merged commit 6eaad7b into NCAS-CMS:lama-to-dask Mar 10, 2022
@davidhassell davidhassell mentioned this pull request Oct 10, 2022
@davidhassell davidhassell deleted the dask-cumsum branch November 15, 2022 09:17
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dask Relating to the use of Dask

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants