Skip to content

Conversation

@davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 1, 2022
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but all good to go, assuming TODODASK - check against daask flatten behaviour has been covered (as per the removed line)?

Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
Copy link
Collaborator Author

Thanks Sadie - you're right that the TODODASK - check against dask flatten behaviour has been covered. It behaves like numpy in that it doesn't allow subsets of axes to be flattened, so that code that does that (the transposing and reshaping) is still there in Data.flatten.

@davidhassell davidhassell merged commit ee78e19 into NCAS-CMS:lama-to-dask Mar 9, 2022
@davidhassell davidhassell deleted the dask-flatten branch November 15, 2022 09:18
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dask Relating to the use of Dask

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants