dask: Data.__contains__
#320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Feb 15, 2022
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
All good, with nice improvements to the test and docstring examples, though one of the new short circuiting cases left me pondering the scope and nature of __contains__ with cf and numpy, so please see my longer in-line comment in case it might elicit some changes, minor or otherwise (after you return from leave of course!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data.__contains__was already daskified, but the unit test was being skipped. This PR re-instates the unit test, and takes an opportunity to improve the code (notable adding some short circuits).