LAMA to Dask: func -> built-in conversion for non-trig. methods
#308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhassell
requested changes
Feb 2, 2022
Collaborator
davidhassell
left a comment
There was a problem hiding this comment.
Nice job. A few minor suggestions, but all tests pass for me. After you've dealt with the comments (in whatever way you want), please go ahead and merge.
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Member
Author
|
Quickly re-running he CI jobs to double check they are still passing, triggering via open-close... |
Member
Author
|
All checks passing, good to go... |
This was referenced Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #302, to tick all sub-issue boxes except the topmost* and in doing so close #303, since
Data.logis now fully migrated (and marked as such) because the/=operator it uses with a non-e/10/2based is applied in 'Dask space' rather thancfspace.Note
* the topmost item, 'the eight trigonometric and hyperbolic methods and their inverses which don't have restricted domains', will be tackled as a separate PR to make it easier for the reviewer to check that the correct eight methods have been converted and in a consistent way, with commenting to explain why the other four such methods have been left as
funccalls. And since the code changes required on all of the methods listed in #302 are largely the same, such that any review feedback can be done as one on them all, and it would be more time-consuming to make seven separate PRs for each, I thought it best to split into just two PRs to cover the Issue (second PR for the trig. methods to follow).