Fix cf.aggregate failures when using the 'dimension' keyword
#284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
One comment (see in-line), otherwise all good:
This is simply a bug in code that was not covered by the units tests.
Bug fixed and a new unit test added which captures the bug (fails on the current master and not here).
sadielbartholomew
approved these changes
Nov 29, 2021
Member
|
Note that the CI test failures are both solely due to the following error:
so somehow the given test file is not being generated. I will look into that separately. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283