-
Notifications
You must be signed in to change notification settings - Fork 23
Improve performance by allowing a saved RegridOperator instance to define the regrid operator
#223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi Sadie - it'd be great if you could cast your eye over this. The main elements are the change to the I took this opportunity to move the regridding methods from the Whilst I have done some work on the Thanks, |
|
Thanks David for the reviewing guidance which all seems very clear. I will review later today.
Excellent idea. I'd also be keen to move out other related aspects if we can find any because the size of the cf |
|
Thanks, Sadie. I'm all for reducing the size of |
Excellent, I will look out for opportunities to do so. I have just observed another indicator that the module is larger than it should be, in that GitHub gives up on syntax highlighting after about ~10,000 lines into a file (or a Python one at least)! |
sadielbartholomew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, performance much improved as per the issue at hand and nothing has broken with the update and refactor as far as I can tell. I only have a few typos to point out (and they can be addressed at a future time if you wish).
|
Thanks, Sadie. All points addressed as per your suggestions (apart from the alphabetical ordering of imports which is best left to robots rather than me!) |
Fixes: #222