Compute non-parametric vertical coordinates #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
…thon into formula_terms
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Collaborator
Author
|
Note NCAS-CMS/cfdm#109 |
sadielbartholomew
approved these changes
Dec 10, 2020
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
I have a small number of further minor comments (some of which should really be addressed pre-merge though will be very quick to fix), but overall this looks great: well tested and well-designed in terms of static methods to provide the code reuse for the logic required for the class methods corresponding to the various standard names with formulas (atmosphere_ln_pressure_coordinate, atmosphere_sigma_coordinate etc.). 🔥
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
…thon into formula_terms
Collaborator
Author
|
Hi Sadie, Thanks as ever for the careful review. I've accepted all of your suggestions - hopefully implementing them correctly! Are we good to go? |
Member
|
Thanks David. Yes this is definitely good to go! Please merge away. |
Collaborator
Author
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
The method is (roughly)
For each coordinate reference construct,
Field.compute_vertical_coordinatescalls functionformulaThe
formulafunction calls the appropriate coordinate-calculator function (e.g.atmosphere_hybrid_height_coordinate) and returns eitherNoneif the vertical coordinates can not be calculated from the coordinate reference constructor
If coordinates were computed then they are inserted into the field construct