Skip to content

'has_year_zero' differences for "months/years since ..." units #434

@sadielbartholomew

Description

@sadielbartholomew

Specifying units of "months since <a date>" or "years since <a date>" (and possibly other options too) in certain calendars can lead to datetime results with the has_year_zero property set to True (e.g. cftime.Datetime360Day(2000, 3, 1, 20, 58, 7, 662446, has_year_zero=True)). However it is not clear how we can specify an equivalent datetime result directly in cf, without having to import cftime separately.

While the underlying issue is whether or not the 'has_year_zero' property is somehow, and should be, exposed to the API, there is also the potential for inconsistency that might have arose in cf due to the change in default value this at cftime version 1.5.1 (see the relevant changelog entries)

Such a default change seems to have caused inconsistencies in the expected and actual outputs from test_Data_months_years, hence I have added a skip until we can investigate this, which for lack of viewable permalink (due to not being master code) provides the summary of:

@unittest.skipIf(
    True,
    "Failing due to 'has_year_zero' differences in actual and expected "
    "outputs: relates to github.com/Unidata/cftime/issues/233, see also "
    "NCAS-CMS/cfunits/commit/ca15e7f6db76fe613db740993b4e45115341d865.",
)

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionGeneral questiontestingIssues related to units tests and their coverage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions