Skip to content

Enable nb_scroll_outputs from latest myst-nb#207

Merged
bsipocz merged 3 commits intoNASA-NAVO:mainfrom
jaladh-singhal:test-nb_scroll_outputs
Jul 14, 2025
Merged

Enable nb_scroll_outputs from latest myst-nb#207
bsipocz merged 3 commits intoNASA-NAVO:mainfrom
jaladh-singhal:test-nb_scroll_outputs

Conversation

@jaladh-singhal
Copy link
Copy Markdown
Contributor

@jaladh-singhal jaladh-singhal commented Jul 3, 2025 •
edited
Loading

This PR is just a test for scroll_outputs functionality upcoming from upstream in executablebooks/MyST-NB#683

Fixes #102
Undoes the #106 (since we have global config, we shouldn't hardcode scroller tag on cell level)

Test if the generated webpages have long outputs scrollable (bonus: also test dark mode style fixes that will come soon) - specifically the Candidate List Solutions (since others are ignored)

@jaladh-singhal jaladh-singhal mentioned this pull request Jul 3, 2025
Merged
@jaladh-singhal jaladh-singhal marked this pull request as draft July 3, 2025 21:14
bsipocz
bsipocz reviewed Jul 4, 2025
View reviewed changes
@bsipocz
Copy link
Copy Markdown
Contributor

bsipocz commented Jul 4, 2025

OK, so everything works even if the config item is added prematurely, before it's available in a release. So I would say we can repurpose the PR and rebase to just keep the config change in here and then merge.

@jaladh-singhal
Copy link
Copy Markdown
Contributor Author

jaladh-singhal commented Jul 4, 2025

OK, so everything works even if the config item is added prematurely, before it's available in a release. So I would say we can repurpose the PR and rebase to just keep the config change in here and then merge.

@bsipocz Sure, let me know when you make a release upstream. I'll update this PR and also remove no-longer-needed cell tags.

@bsipocz
Copy link
Copy Markdown
Contributor

bsipocz commented Jul 4, 2025

I think it will be early next week from Scipy as there is a least one other PR close to the finish line.

@bsipocz
Copy link
Copy Markdown
Contributor

bsipocz commented Jul 14, 2025

Now as the release is out, can you rebase this to only have the config change left, and also add the MyST-NB>=1.3 pin to the requirements?
Thanks!

@bsipocz bsipocz added the infrastructure changes to the infrastructure rather than content label Jul 14, 2025
@jaladh-singhal
Copy link
Copy Markdown
Contributor Author

jaladh-singhal commented Jul 14, 2025

@bsipocz sure - it's on my TODOs for today/tomorrow

@jaladh-singhal jaladh-singhal force-pushed the test-nb_scroll_outputs branch from 8706879 to c8ada38 Compare July 14, 2025 23:09
bsipocz
bsipocz reviewed Jul 14, 2025
View reviewed changes
@bsipocz bsipocz marked this pull request as ready for review July 14, 2025 23:11
@jaladh-singhal jaladh-singhal changed the title Test nb_scroll_outputs from myst-nb branch Enable nb_scroll_outputs from latest myst-nb Jul 14, 2025
@bsipocz bsipocz merged commit 40207d7 into NASA-NAVO:main Jul 14, 2025
1 of 11 checks passed
@bsipocz
Copy link
Copy Markdown
Contributor

bsipocz commented Jul 14, 2025

Thanks @jaladh-singhal, this scrolling fix is epic, I love it!

@jaladh-singhal jaladh-singhal deleted the test-nb_scroll_outputs branch July 14, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

infrastructure changes to the infrastructure rather than content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ENH: Make long cells in the output scrollable

2 participants

@jaladh-singhal @bsipocz