fix(indexer): improve ingestion client arg validation#25434
Merged
Conversation
## Description Previously we allowed multiple "source" arguments to be passed when configuring the ingestion client, but we had an implicit precedence order which meant that only one gets picked. This was based on a misunderstanding of how `clap`'s derive macro works. The set-up now makes sure that exactly one source is provided, and RPC credentials can only be supplied if `--rpc-api-url` is provided. ## Test plan New unit tests: ``` $ cargo nextest run -p sui-indexer-alt-framework ```
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
henryachen
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we allowed multiple "source" arguments to be passed when configuring the ingestion client, but we had an implicit precedence order which meant that only one gets picked.
This was based on a misunderstanding of how
clap's derive macro works.The set-up now makes sure that exactly one source is provided, and RPC credentials can only be supplied if
--rpc-api-urlis provided.Test plan
New unit tests:
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.