Disable object_store internal retries for all cloud backends#25324
Merged
nickvikeras merged 2 commits intomainfrom Feb 6, 2026
Merged
Disable object_store internal retries for all cloud backends#25324nickvikeras merged 2 commits intomainfrom
nickvikeras merged 2 commits intomainfrom
Conversation
object_store's default retry logic hides transient errors (429s, 5xx) from the framework's own retry/backoff, preventing callers from reacting to pressure signals. Disable retries for S3, GCS, Azure, and HTTP backends in both the ingestion client and checkpoint blob indexer.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
amnn
approved these changes
Feb 6, 2026
Contributor
amnn
left a comment
There was a problem hiding this comment.
LGTM, thanks! Didn't even realise that object_store was performing its own retries.
|
|
||
| /// Disable object_store's internal retries so that transient errors (429s, 5xx) propagate | ||
| /// immediately to the framework's own retry logic. | ||
| fn retry_config() -> RetryConfig { |
Contributor
There was a problem hiding this comment.
nit: given this is specific to StoreClient, why not make it a privat top-level function or const there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
object_store's default retry logic hides transient errors (429s, 5xx) from the framework's own retry/backoff, preventing callers from reacting to pressure signals.
In order to build adaptive concurrency limits that react to upstream/downstream errors, we need the framework to see the errors.
Test plan
I have tested it during a testnet backfill as part of a larger effort to enable adaptive rate limiting.
Release notes