Update kv-store readers to read the new schema with fallback#25191
Merged
nickvikeras merged 3 commits intomainfrom Feb 3, 2026
Merged
Update kv-store readers to read the new schema with fallback#25191nickvikeras merged 3 commits intomainfrom
nickvikeras merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
be713d1 to
1992431
Compare
1992431 to
8ac3b79
Compare
8ac3b79 to
f60a8f3
Compare
00c91f0 to
268dbac
Compare
f60a8f3 to
46d4712
Compare
bmwill
approved these changes
Feb 3, 2026
46d4712 to
3a5d271
Compare
920f45a to
87eeaba
Compare
c8bc202 to
4c9cccb
Compare
amnn
reviewed
Feb 6, 2026
Contributor
There was a problem hiding this comment.
This will be a larger change (and not blocking) but it would be good to update GraphQL to fetch specific watermarks based on the pipelines it is actively tracking from BigTable.
That change can wait until after we get rid of raw BigTable support, and are just using gRPC-based access though, and it needs to be coupled with a change to how we calculate the AvailableRange so that we pay attention to retention for KV lookups cc @henryachen, tracking here: https://linear.app/mysten-labs/issue/DVX-1987/per-pipeline-archival-watermarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #25143 to actually read the new schema. Fallback to the old schema is left in place while we wait for the backfill to complete.
Test plan
I tried running the e2e test with --write-legacy-data false and ensured everything could still be read when only writing the new schema.
Release notes