Skip to content

feat: Add support for including service options from GET /service endpoint #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
M4tini merged 1 commit into from
Jan 8, 2026
Merged

feat: Add support for including service options from GET /service endpoint #260

M4tini merged 1 commit into from
Jan 8, 2026

Conversation

@DannyvdSluijs
Copy link
Contributor

@DannyvdSluijs DannyvdSluijs commented Jan 7, 2026

This PR adds support for including service options from GET /service endpoint.

This follows the same logic as found in other resources such as the MyParcelCom\ApiSdk\Resources\ServiceRate

@M4tini M4tini self-assigned this Jan 8, 2026
M4tini
M4tini approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@M4tini M4tini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we probably also need to add mapping in the ResourceFactory class. I will do this before the release (since I cannot add commits to this PR).

Edit: that additional stuff does not seem to be necessary :)

@M4tini M4tini merged commit 4038bab into MyParcelCOM:develop Jan 8, 2026
@M4tini M4tini mentioned this pull request Jan 8, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M4tini M4tini M4tini approved these changes

Assignees

@M4tini M4tini

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DannyvdSluijs @M4tini