fix: Resolve Implicitly marking parameter $... as nullable is deprecated deprecation messages #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted deprecation messages
These deprecations are visible when running find ./src -type f -name '*.php' -exec php -l {} \;
grep -v 'No syntax errors' using PHP 8.4
M4tini
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.4 implicit nullable types have been deprecated, this PR makes the implicit nullable type explicit by prefixing the type with the question mark symbol.
These deprecations where visible when running find ./src -type f -name '*.php' -exec php -l {} ; grep -v 'No syntax errors' using PHP 8.4