fix automated releasing: docker output location#82
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the GitHub Actions release workflow to resolve path issues by using the absolute workspace directory for build outputs and adds a diagnostic step to inspect workspace contents. Flow diagram for updated release workflow stepsflowchart TD
A["Docker Build Output to ${{ github.workspace }}/.build"] --> B["List workspace files"] --> C["Create GitHub Release using ${{ github.workspace }}/.build/snaggle#Snaggle"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Remove the temporary debug step that lists the workspace files once the path issue is confirmed.
- There's an extra single quote at the end of the
gh release createcommand – please remove it to avoid shell errors. - Consider simplifying path references by using relative paths (Actions already runs in the workspace) or consistently using $GITHUB_WORKSPACE.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove the temporary debug step that lists the workspace files once the path issue is confirmed.
- There's an extra single quote at the end of the `gh release create` command – please remove it to avoid shell errors.
- Consider simplifying path references by using relative paths (Actions already runs in the workspace) or consistently using $GITHUB_WORKSPACE.
## Individual Comments
### Comment 1
<location> `.github/workflows/release.yml:117` </location>
<code_context>
GH_TOKEN: ${{ github.token }}
run: |
- gh release create ${{ needs.version.outputs.semver }} --generate-notes ./.build/snaggle#Snaggle ${{ needs.version.outputs.semver }}'
+ gh release create ${{ needs.version.outputs.semver }} --generate-notes ${{ github.workspace }}/.build/snaggle#Snaggle ${{ needs.version.outputs.semver }}'
</code_context>
<issue_to_address>
**issue (typo):** Check for unintended trailing single quote in the release command.
This trailing single quote may be a typo and could break the shell command. Please confirm if it's needed.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| gh release create ${{ needs.version.outputs.semver }} --generate-notes ./.build/snaggle#Snaggle ${{ needs.version.outputs.semver }}' | ||
| gh release create ${{ needs.version.outputs.semver }} --generate-notes ${{ github.workspace }}/.build/snaggle#Snaggle ${{ needs.version.outputs.semver }}' |
There was a problem hiding this comment.
issue (typo): Check for unintended trailing single quote in the release command.
This trailing single quote may be a typo and could break the shell command. Please confirm if it's needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 11 11
Lines 566 566
=======================================
Hits 419 419
Misses 104 104
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix the release workflow to use the correct build artifact location and add debugging for workspace contents.
Bug Fixes:
Enhancements: