Skip to content

Fix error #43 when file exists#45

Merged
MusicalNinjaDad merged 2 commits into
mainfrom
FileExists
Oct 25, 2025
Merged

Fix error #43 when file exists#45
MusicalNinjaDad merged 2 commits into
mainfrom
FileExists

Conversation

@MusicalNinjaDad

@MusicalNinjaDad MusicalNinjaDad commented Oct 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

Fixes #43

Summary by Sourcery

Fix handling of existing files in the link routine and add a test to ensure idempotent behavior when a file already exists

Bug Fixes:

  • Treat only identical existing files as non-errors in the link function instead of the previous inverted logic

Tests:

  • Add TestFileExists to verify that snaggle.Snaggle succeeds when the target file already exists and can be called repeatedly without error

@sourcery-ai

sourcery-ai Bot commented Oct 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fix handling of existing identical files by correcting the EEXIST conditional logic and add a test to verify no error when the target file already exists.

File-Level Changes

Change Details Files
Correct EEXIST error-handling condition to ignore error when target and source are identical
  • Removed negation on SameFile check
  • Treat identical-file case as success
 snaggle.go
Add a test to ensure no error is returned when the file already exists
  • Introduced TestFileExists with workspace temp directory setup
  • Invoke Snaggle twice on the same target to simulate existing file
  • Assert that no error occurs on subsequent calls
 snaggle_test.go
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Oct 25, 2025
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@MusicalNinjaDad MusicalNinjaDad merged commit 13e417d into main Oct 25, 2025
8 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the FileExists branch October 25, 2025 12:25
@codecov

codecov Bot commented Oct 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.87%. Comparing base (ec5c7b6) to head (5bc7df2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   71.35%   71.87%   +0.52%     
==========================================
  Files           5        5              
  Lines         384      384              
==========================================
+ Hits          274      276       +2     
+ Misses         75       73       -2     
  Partials       35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails in multistage build when re-linking libc.so.6 (file exists)

1 participant

@MusicalNinjaDad