CMake: replace QTKEYCHAIN_STATIC with standard BUILD_SHARED_LIBS

Be-ing · frankosterfeld · commit 43be122f1aaf · 2021-11-11T15:27:46.000+01:00
BUILD_SHARED_LIBS is the standard CMake variable for controlling whether libraries are built dynamically or statically. Using a nonstandard variable requires extra work for packagers. https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html Fixes frankosterfeld#180
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -22,7 +22,7 @@ include(ECMGeneratePriFile)
 option(BUILD_WITH_QT6 "Build qtkeychain with Qt 6" OFF)
 option(BUILD_TEST_APPLICATION "Build test application" OFF)
 option(BUILD_TRANSLATIONS "Build translations" ON)
-option(QTKEYCHAIN_STATIC "Build static library" OFF)
+option(BUILD_SHARED_LIBS "Build dynamic library" ON)
 
 if(CMAKE_SYSTEM_NAME STREQUAL Android)
     set(ANDROID 1)
@@ -199,11 +199,7 @@ set(qtkeychain_TR_FILES
 )
 
 set(QTKEYCHAIN_TARGET_NAME qt${QTKEYCHAIN_VERSION_INFIX}keychain)
-if(NOT QTKEYCHAIN_STATIC)
-    add_library(${QTKEYCHAIN_TARGET_NAME} SHARED ${qtkeychain_SOURCES} ${qtkeychain_MOC_OUTFILES} ${qtkeychain_QM_FILES})
-else()
-    add_library(${QTKEYCHAIN_TARGET_NAME} STATIC ${qtkeychain_SOURCES} ${qtkeychain_MOC_OUTFILES} ${qtkeychain_QM_FILES})
-endif()
+add_library(${QTKEYCHAIN_TARGET_NAME} ${qtkeychain_SOURCES} ${qtkeychain_MOC_OUTFILES} ${qtkeychain_QM_FILES})
 if(WIN32)
     set_target_properties( ${QTKEYCHAIN_TARGET_NAME} PROPERTIES DEBUG_POSTFIX "d" )
 endif()
