Refactor: use luarocks for lua-zip and lua-yajl#72
Merged
vadi2 merged 1 commit intoMudlet:masterfrom Apr 18, 2020
Merged
Conversation
Using the former one should mean we no longer need to compile it into our MacOs application, and as it is a different one (Brimworks rather than Kepler project, as is the lua-yajl module) that does not use the zziplib/libzzip library it should save us some hassle as that library is causing problems with the MacOS CI at the moment. As we are *adding* the modules directly into the same directory as the Mudlet executable it does not matter if the current CI builds of that do not call upon it yet. I.e. this PR can go into the installers repo before we modify the main repo to use it... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
approved these changes
Apr 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the former one should mean we no longer need to compile it into our MacOs application, and as it is a different one (Brimworks rather than Kepler project, as is the
lua-yajlmodule) that does not use thezziplib/libzziplibrary it should save us some hassle as that library is causing problems with the MacOS CI at the moment.As we are adding the modules directly into the same directory as the Mudlet executable it does not matter if the current CI builds of that do not call upon it yet. I.e. this PR can go into the installers repo before we modify the main repo to use it...
Signed-off-by: Stephen Lyons slysven@virginmedia.com