fix edbee#140, Fix Array index out of bounds assertion loading with TextDocumentSerializer

gamecreature · gamecreature · commit 7fbdd6455d25 · 2023-04-10T21:40:25.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 edbee.lib:
 
+- fix #140, Fix Array index out of bounds assertion loading with TextDocumentSerializer
 - fix #136, BREAKING CHANGE: return type TextEditorController::executeCommand changed to void.
   - changed TextEditorController slot arguments to fully-qualified types.
 - ref #136, remove TextDocumentController readonly methods from slots
diff --git a/edbee-lib/edbee/io/textdocumentserializer.cpp b/edbee-lib/edbee/io/textdocumentserializer.cpp
@@ -42,14 +42,14 @@ bool TextDocumentSerializer::loadWithoutOpening( QIODevice* ioDevice )
     QTextDecoder* textDecoder=0;
 
     // read the buffer
-    QByteArray bytes(blockSize_ + 1,0);
+    QByteArray bytes(blockSize_ + 1, 0);
     QString remainingBuffer;
 
     /// TODO: atEnd doesn't seem to work !?!
 /// TODO: implement isStopRequested to stop loading if required
     while( /*ioDeviceRef_->atEnd() &&*/ true /*!isStopRequested()*/ ) {
 
-        int bytesRead = ioDevice->read( bytes.data(), blockSize_ );
+        int bytesRead = ioDevice->read( bytes.data(), blockSize_ - 1);
         if( bytesRead > 0 ) {
             bytes[bytesRead + 1] = 0; // 0 terminate the read bytes
 
