Subset of clang-format changes.#978
Merged
ahmedcharles merged 2 commits intoMudlet:developmentfrom Apr 28, 2017
ahmedcharles:format
Merged
Subset of clang-format changes.#978ahmedcharles merged 2 commits intoMudlet:developmentfrom ahmedcharles:format
ahmedcharles merged 2 commits intoMudlet:developmentfrom
ahmedcharles:format
Conversation
SlySven
reviewed
Apr 28, 2017
| } | ||
| else | ||
| } else { | ||
| return weight; // NOTE: if no exit weight has been set: exit weight = room weight |
Member
There was a problem hiding this comment.
🤔 Blast, I thought I had properly coded things so that the weight of the destination room was used if there was not an exit weight. Or may-haps it is already done by the code that uses the details so things are OK after all...!
Anyhow nothing to do about it here and now.
SlySven
approved these changes
Apr 28, 2017
Member
SlySven
left a comment
There was a problem hiding this comment.
OK, but there is one place where I prefer the prior layout to stand - can we do that?
| exitWeightsCopy, exitStubsCopy, exitLocksCopy, doorsCopy, | ||
| customLinesCopy, customLinesColorCopy, customLinesStyleCopy, customLinesArrowCopy, | ||
| roomRemapping ); | ||
| auditExit(north, |
Member
There was a problem hiding this comment.
👎 I think the one per line is not helpful here - OTOH I was the one who put them as they were so I may not be entirely impartial...!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.