Implemented the improvements from #965 review#968
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Apr 28, 2017
Merged
Conversation
Ones I felt comfortable with anyhow
ahmedcharles
approved these changes
Apr 26, 2017
SlySven
approved these changes
Apr 27, 2017
Member
SlySven
left a comment
There was a problem hiding this comment.
The removal of the Qt::Color(...) around Qt Global colour constants has a wider incidence than just the case here - so it is something to add to the "general clean-up" list as things to be done if spotted I guess...! 😁
Member
Author
|
Sounds good to me.
…On Thu, 27 Apr 2017 2:39 pm Stephen Lyons, ***@***.***> wrote:
***@***.**** approved this pull request.
The removal of the Qt::Color(...) around Qt Global colour constants has a
wider incidence than just the case here - so it is something to add to the
"general clean-up" list as things to be done if spotted I guess...! 😁
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#968 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGxjELwgAIEm8ZsB6_3iRIJlQM3PNMEks5r0IxqgaJpZM4NJTOh>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ones I felt comfortable with anyhow
Taggign @Mudlet/core-cpp for review