Upgrade IRC library to Communi 3.5.0#942
Merged
ahmedcharles merged 8 commits intoMudlet:developmentfrom Apr 22, 2017
itsTheFae:upgrade-communi35
Merged
Upgrade IRC library to Communi 3.5.0#942ahmedcharles merged 8 commits intoMudlet:developmentfrom itsTheFae:upgrade-communi35
ahmedcharles merged 8 commits intoMudlet:developmentfrom
itsTheFae:upgrade-communi35
Conversation
Removed old entries in INCLUDEPATH, SOURCES, HEADERS and DISTFILES directives. They are handled in the src.pri file. CMakeLists.txt for Communi was removed temporarilly (missing from 3.5 source, needs updates.)
Changed header includes. Updated IrcSession to IrcConnection Renamed `session` member to `connection` Updated IrcMessage::fromCommand(...) to cmd->toMessage(...)
…pgrade-communi35
Member
|
Tagging @Mudlet/core-cpp for review |
Contributor
|
Note, I originally wrote the CMakeLists.txt file, not the communi project. So, it was never part of their distribution. |
Member
|
Would you be able to update it for the new Communi? |
Contributor
|
I updated it, though my commit probably looks weird since it includes changes from the latest development as well. I'd like to apply this after #943. |
vadi2
approved these changes
Apr 22, 2017
Member
vadi2
left a comment
There was a problem hiding this comment.
Definitely looks weird and not feasible to review so I'll roll with it and any issues found can be fixed up later.
Contributor
Author
|
@ahmedcharles Thanks a bunch for the help with this! Sorry if it was a bit of a mess to clean up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the 1.2.1 library completely and inserts the 3.5.0 version in it's place.
Changes in mudlet's
src.proremoves all references to the irc library and replaces them with a .pri include at the top of the file.Changes in the irc dialog involved renaming
IrcSessiontoIrcConnectionand thesessionpointer toconnectionthroughout the other files.Just for easy reference, the library source, docs, and change logs can be found here: http://communi.github.io/