Remove unused/dead/commented code.#925
Remove unused/dead/commented code.#925ahmedcharles merged 2 commits intoMudlet:developmentfrom ahmedcharles:dead
Conversation
Also do some minor whitespace changes.
| pConsole->show();//NOTE: this is important for Apple OSX otherwise the console isnt displayed | ||
| } | ||
|
|
||
| void mudlet::closeEvent(QCloseEvent *event) |
There was a problem hiding this comment.
Is this not overriding http://doc.qt.io/qt-5/qwidget.html#closeEvent ?
There was a problem hiding this comment.
That's true. Thanks for the catch.
There was a problem hiding this comment.
I think it would be an appropriate place for the new C++11 override keyword yeah?
There was a problem hiding this comment.
Yep, a pretty essential function - it is used!
There was a problem hiding this comment.
You specify override on the declaration, which it is for this one. I just didn't notice it when I deleted it.
| else if (!myOptionState[255]) | ||
| //only if the option is currently disabled | ||
| { | ||
| if( //( option == OPT_SUPPRESS_GA ) || |
There was a problem hiding this comment.
Commenting this out/removing it also makes line 822 | 797 (before|after) unreachable...!
|
|
||
| signals: | ||
|
|
||
| void signal_establish_connection( QString profile_name, int historyVersion ); |
There was a problem hiding this comment.
🤔 I believe int historyVersion is unused throughout the whole application.
|
|
||
|
|
||
| private: | ||
| bool removeDir( QString dirName, QString originalPath ); |
There was a problem hiding this comment.
IIRC This was a compatibility workaround for Qt4.x and early Qt5.x versions - there is/was a duplicate elsewhere (I think in the Hostclass; which couldn't be used in this class because there may not be a Host instance to run it from...! 😄)
No description provided.