Fix: memory leaks in sound player, dialogs by vadi2 · Pull Request #9142 · Mudlet/Mudlet

vadi2 · 2026-04-04T07:32:05Z

Brief overview of PR changes/additions

Fixes memory leaks from playing sounds, opening the room exits dialog, opening Preferences, right-clicking the console, connecting to MUDs with compression, and viewing changelogs

Motivation for adding to Mudlet

Better memory management.

Other info (issues closed, discussion etc)

3. TMediaPlayer destructor leaks TMediaPlaylist + QAudioOutput

playSoundFile() [TLuaInterpreterMedia.cpp:703]
  → TMedia::playMedia() [TMedia.cpp:47] → play() [TMedia.cpp:1485]
    → getMediaPlayer() [TMedia.cpp:1150]
      → make_shared<TMediaPlayer>(mpHost, mediaData) [TMedia.cpp:1193]
        → constructor: mPlaylist(new TMediaPlaylist)       ← LEAK #1 [TMedia.h:47]
        → constructor: setAudioOutput(new QAudioOutput())  ← LEAK #2 [TMedia.h:50]
    → updateMediaPlayerList() [TMedia.cpp:1102]
      → purgeStoppedMediaPlayers() [TMedia.cpp:1056] (when list > 25)
        → shared_ptr destroyed → ~TMediaPlayer() = default  ← NEVER DELETES [TMedia.h:52]

6. dlgRoomExits TExit objects never freed

Right-click room → "Set exits..." [RoomContextMenuHandler.cpp:196]
  → T2DMap::slot_setExits() [T2DMap.cpp:4271]
    → new dlgRoomExits(...) [T2DMap.cpp:4278] + setAttribute(WA_DeleteOnClose) [T2DMap.cpp:4280]
      → init() [dlgRoomExits.cpp:279]
        → initExit() x12 [dlgRoomExits.cpp:1633-1775]
          → originalExits[dir] = makeExitFromControls(dir) [dlgRoomExits.cpp:1599]
            → new TExit() [dlgRoomExits.cpp:1968]  ← ALLOCATED
        → new TExit() per special exit [dlgRoomExits.cpp:1782] → originalSpecialExits[dir] [line 1848]
  User closes → ~dlgRoomExits() [dlgRoomExits.cpp:285] ← EMPTY, never deletes TExit objects

7. dlgProfilePreferences QKeySequence* leak (no destructor)

mudlet::showOptionsDialog() [mudlet.cpp:3578]
  → new dlgProfilePreferences(this, pHost) [mudlet.cpp:3585]
  → setAttribute(WA_DeleteOnClose) [mudlet.cpp:3603]
    → constructor loop [dlgProfilePreferences.cpp:1394-1399]:
        new QKeySequence(*pHost->profileShortcuts.value(key)) [line 1398]
        currentShortcuts.insert(key, sequence) [line 1399]  ← 17 raw pointers stored
  User closes → WA_DeleteOnClose triggers delete
    → implicit ~dlgProfilePreferences() ← NO DESTRUCTOR EXISTS
      → QMap destroyed, pointer values NOT deleted

10. ctelnet missing inflateEnd in destructor

Server sends WILL COMPRESS2 → processSocketData [ctelnet.cpp:4876-4880]
  → mNeedDecompression = true → initStreamDecompressor()
    → inflateInit(&mZstream) [ctelnet.cpp:4514]  ← allocates ~256KB

Connection drops → slot_socketDisconnected() [ctelnet.cpp:627]
  → mNeedDecompression = false [line 663]  ← NO inflateEnd()
  → reset() [line 664] ← NO inflateEnd()
  → ~cTelnet() [line 158] ← NO inflateEnd()
  (only inflateEnd is in decompressBuffer:4532, on Z_STREAM_END from server)

11. ctelnet QNetworkReply leak on file error paths

slot_replyFinished() [ctelnet.cpp:1365]
  → reply->error() == NoError [line 1398]
    → file.open() fails [line 1400] → return ← LEAK (no reply->deleteLater())
    → file.commit() fails [line 1409] → return ← LEAK (no reply->deleteLater())
  (compare: error path at line 1393 correctly calls reply->deleteLater())

15. TTextEdit QAction accumulation (5-10 per right-click)

Right-click on console → mouseReleaseEvent [TTextEdit.cpp:2287]
  → new QAction(tr("Copy"), this) [line 2374]      ← parented to TTextEdit, not QMenu
  → new QAction(tr("Copy HTML"), this) [line 2385]
  → new QAction(tr("Copy as image"), this) [line 2389]
  → new QAction(tr("Select all"), this) [line 2392]
  → new QAction(tr("Search on %1"), this) [line 2397]
  → (+ conditional actions at 2416, 2434, 2438, 2448, 2465)
  → popup = new QMenu(this) + WA_DeleteOnClose [line 2406-2407]
  → Menu closes → QMenu deleted, but QActions survive as TTextEdit children ← ACCUMULATE

17. Updater changelog dialogs leaked

Help → Show changelog → Updater::showChangelog() [updater.cpp:202]
  → new dblsqd::UpdateDialog(feed, ...) ← no parent [line 202]
  → changelogDialog->show() [line 204] ← non-blocking, pointer lost at scope end
  (no WA_DeleteOnClose set; same at showFullChangelog:218)

20. ModernGLWidget mTexCoordBuffer.destroy() missing

initializeGL() → setupBuffers() [modern_glwidget.cpp:146]
  → mTexCoordBuffer.create() [line 183]
~ModernGLWidget() → cleanup() [line 70]
  → mVertexBuffer.destroy()  [line 78] ✓
  → mColorBuffer.destroy()   [line 79] ✓
  → mNormalBuffer.destroy()  [line 80] ✓
  → mIndexBuffer.destroy()   [line 81] ✓
  → mInstanceBuffer.destroy() [line 82] ✓
  → mTexCoordBuffer.destroy() ← MISSING between lines 82 and 83
  → mVAO.destroy()           [line 83] ✓

21. dlgComposer context menu + Hunspell suggestions

Right-click in composer → slot_contextMenu() [dlgComposer.cpp:226]
  → createStandardContextMenu() [line 228] ← returns new QMenu*, no parent
  → fillSpellCheckList() [line 233] → Hunspell_suggest() [line 331,335] ← allocates lists
  → popup->popup() [line 237] ← non-blocking, pointer lost
  ← QMenu leaked (no WA_DeleteOnClose, no deleteLater)
  ← If dismissed without selection: Hunspell_free_list() never called [only at line 468,472]

22-24. Lower-impact (also in this branch)

dlgColorTrigger after exec() [dlgTriggerEditor.cpp:12469,12532]:
  → new dlgColorTrigger(this, ...) → exec() → no delete pD

Hunspell shared dictionary [mudlet.cpp:4768]:
  → mpHunspell_sharedDictionary = nullptr ← missing Hunspell_destroy() before

ExitsTreeWidget takeTopLevelItem [exitstreewidget.cpp:45]:
  → takeTopLevelItem(indexOfTopLevelItem(pItem)) ← return value discarded, never deleted

Use std::unique_ptr for TMediaPlaylist ownership. Delete QAudioOutput in destructor since setAudioOutput() doesn't take ownership in Qt6.

QKeySequence is a lightweight, implicitly-shared value class that doesn't need heap allocation. The pointer-based QMap entries were never freed, leaking on every dialog close.

QActions were parented to TTextEdit (this) but the QMenu used WA_DeleteOnClose, so the QActions leaked on every right-click. Parent them to the QMenu so they're deleted with it.

- Call inflateEnd() on disconnect and destruction when MCCP compression is active (~256KB leaked per connect/disconnect cycle) - Add reply->deleteLater() to early-return error paths in slot_replyFinished() that were skipping cleanup

add-deployment-links · 2026-04-04T07:32:09Z

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

linux: https://make.mudlet.org/snapshots/74983a/Mudlet-4.20.1-testing-pr9142-63a5750d-linux-x64.AppImage.tar (commit 63a5750)
osx intel: https://make.mudlet.org/snapshots/f5f4a6/Mudlet-4.20.1-testing-pr9142-63a5750d-x86_64.dmg (commit 63a5750)
osx arm: https://make.mudlet.org/snapshots/50a571/Mudlet-4.20.1-testing-pr9142-63a5750d-arm64.dmg (commit 63a5750)
windows 64 bit: https://make.mudlet.org/snapshots/6f1984/Mudlet-4.20.1-testing-pr9142-63a5750d-windows-64.zip (commit 63a5750)

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

github-actions · 2026-04-04T07:32:41Z

	Warnings
⚠️	PR makes changes to 13 source files. Double check the scope hasn't gotten out of hand

Generated by 🚫 dangerJS against 63a5750

greptile-apps · 2026-04-04T07:37:18Z

_{Reviews (1): Last reviewed commit: "Apply clang-format to changed files" | Re-trigger Greptile}

src/Host.cpp

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

mpconley · 2026-04-04T11:35:40Z

Verified sound/music works.

ZookaOnGit

everything looks as per normal

vadi2 added 7 commits April 4, 2026 09:23

Fix memory leaks in TMediaPlayer destructor

d22a783

Use std::unique_ptr for TMediaPlaylist ownership. Delete QAudioOutput in destructor since setAudioOutput() doesn't take ownership in Qt6.

Fix: memory leak of TExit objects in dlgRoomExits

48e3c10

Fix memory leak: use QKeySequence by value in currentShortcuts map

ded2b35

QKeySequence is a lightweight, implicitly-shared value class that doesn't need heap allocation. The pointer-based QMap entries were never freed, leaking on every dialog close.

Fix memory leak: parent QActions to QMenu in TTextEdit context menu

84b7b39

QActions were parented to TTextEdit (this) but the QMenu used WA_DeleteOnClose, so the QActions leaked on every right-click. Parent them to the QMenu so they're deleted with it.

Fix misc memory leaks across codebase

b7a40e1

Apply clang-format to changed files

fa654ad

vadi2 requested a review from a team as a code owner April 4, 2026 07:32

greptile-apps bot reviewed Apr 4, 2026

View reviewed changes

src/Host.cpp Outdated Show resolved Hide resolved

Update src/Host.cpp

63a5750

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

ZookaOnGit added this to the 4.21.0 next release milestone Apr 7, 2026

ZookaOnGit approved these changes Apr 7, 2026

View reviewed changes

vadi2 merged commit 05a4937 into Mudlet:development Apr 8, 2026
12 checks passed

vadi2 deleted the fix/leak-cpp-qt-resources branch April 8, 2026 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: memory leaks in sound player, dialogs#9142

Fix: memory leaks in sound player, dialogs#9142
vadi2 merged 8 commits intoMudlet:developmentfrom
vadi2:fix/leak-cpp-qt-resources

vadi2 commented Apr 4, 2026 •

edited

Loading

Uh oh!

add-deployment-links bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Apr 4, 2026

Uh oh!

Uh oh!

mpconley commented Apr 4, 2026

Uh oh!

ZookaOnGit left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vadi2 commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief overview of PR changes/additions

Motivation for adding to Mudlet

Other info (issues closed, discussion etc)

3. TMediaPlayer destructor leaks TMediaPlaylist + QAudioOutput

6. dlgRoomExits TExit objects never freed

7. dlgProfilePreferences QKeySequence* leak (no destructor)

10. ctelnet missing inflateEnd in destructor

11. ctelnet QNetworkReply leak on file error paths

15. TTextEdit QAction accumulation (5-10 per right-click)

17. Updater changelog dialogs leaked

20. ModernGLWidget mTexCoordBuffer.destroy() missing

21. dlgComposer context menu + Hunspell suggestions

22-24. Lower-impact (also in this branch)

Uh oh!

add-deployment-links bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test versions

Uh oh!

github-actions bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Apr 4, 2026

Uh oh!

Uh oh!

mpconley commented Apr 4, 2026

Uh oh!

ZookaOnGit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vadi2 commented Apr 4, 2026 •

edited

Loading

add-deployment-links bot commented Apr 4, 2026 •

edited

Loading

github-actions bot commented Apr 4, 2026 •

edited

Loading