Infra: Modernize MxpTag::asString() internally#8307
Merged
Kebap merged 5 commits intoMudlet:developmentfrom Oct 6, 2025
Merged
Infra: Modernize MxpTag::asString() internally#8307Kebap merged 5 commits intoMudlet:developmentfrom
Kebap merged 5 commits intoMudlet:developmentfrom
Conversation
vadi2
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Internal refactoring, no functional changes.
.arg()usedidn't work as expected with multiple code linesQStringBuilderwith % operatorMotivation for adding to Mudlet
Fix #8306
Enhance #3625 by @gcms
Other info (issues closed, discussion etc)
Increasing readability, shorting code ~50%.